[MPDX-8386] Redirect after login

[canac]

Description

Redirect the user back to the page they were trying to go to after they successfully log in.

Looking at the redirect trace in the DevTools network tab (select preserve log, filter by Doc to see page loads, and look at the Location response header), it appears that after sign in, NextAuth, redirects back to the page that initiated the login, in our case, /login?redirect=xxx. Our getServerSideProps function on the login page notices that we have a session and a redirect URL and redirects the user one last time to their original page.

Testing

• Go to a page that isn't a dashboard page (for example, tasks).
• Copy the URL.
• Sign out of MPDX and Okta.
• Navigate to the URL you copied.
• Ensure that when it takes you to the login page, ?redirect is set to the tasks page.
• Ensure that you are redirected to the tasks page after logging in.

MPDX-8386

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://8386-login-redirect.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 1c203d1

No significant changes found

[dr-bizz]

This looks great! Should we automattically start to log users in when they are redirected to the login screen?

[dr-bizz]

Why are we removing this window.location.pathname !== '/login'

[canac]

The Apollo client is no longer present on the login page, so it is impossible to receive GraphQL errors on the login page.

[canac]

Should we automatically start to log users in when they are redirected to the login screen?

Sorry, but I'm not sure what you mean.

[canac]

Should we automatically start to log users in when they are redirected to the login screen?

@dr-bizz Do you mean adjusting this useEffect to always run regardless of whether immediateSignIn is true or false? Or did you mean something else?

useEffect(() => {
  if (immediateSignIn) {
    signIn(signInAuthProviderId);
  }
}, []);

[dr-bizz]

Should we automatically start to log users in when they are redirected to the login screen?

Sorry, but I'm not sure what you mean.

Sorry, I can add more context. When we redirect users from the page they were on to the login page, we shouldn't add another click to the user, we should start to log the users in as soon as they land on the login. They will need to add their login details.

Yes, It's using the immediateSignIn when users are redirected to the login screen when they are not authenticated.