Show Received on pledge modal to avoid confusion #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://add-received-option-to-avoid-confusion.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 7fe882a No significant changes found |
canac
approved these changes
Nov 4, 2024
|
|
||
| const { findByText } = render( | ||
| <ThemeProvider theme={theme}> | ||
| <TestRouter router={router}> | ||
| <GqlMockedProvider<{ UserOption: UserOptionQuery }> mocks={mocks}> | ||
| <ContactsWrapper> | ||
| <> | ||
| <Component /> | ||
| <ContactsContext.Provider |
There was a problem hiding this comment.
Do you know why this helps? ContactsWrapper already wraps its children in <ContactsContext.Provider>.
There was a problem hiding this comment.
My guess is that the viewMode was getting set randomly, but I could be wrong. I figured if I controlled all the properties, I would know for sure it would pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the "Received" option back to the pledge modal. Looking back at previous messages, it looks like users can try to put the contact into "Received." Most of the time, the server will override their choice, but not always.
Putting it back this way will make it simpler for users until we overhaul the appeals Committed->Given process.
Test:
Checklist: