-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8425 Require Task Action on Mass Actions #1171
Conversation
Preview branch generated at https://task-changes.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 8031fd4 No significant changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is looking good. I found an error when you select a phase, it shows the activity dropdown, but if you click away from the dropdown, it autoselects the first option, which is the first issue, and the second issue is that it doesn't recognise it is selected.
If you select another option or select it properly, it works. I know these errors were here before, but since we are making the activity dropdown required if the task phase is selected, it means we will have to fix them.
src/components/Task/MassActions/EditTasks/MassActionsEditTasksModal.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you for fixing this!
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8425&sprint=1282#
Checklist: