Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8425 Require Task Action on Mass Actions #1171

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8425&sprint=1282#

  • Require Task Action on mass edit modal

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Nov 1, 2024
@caleballdrin caleballdrin requested a review from dr-bizz November 1, 2024 20:45
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Preview branch generated at https://task-changes.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Bundle sizes [mpdx-react]

Compared against 8031fd4

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good. I found an error when you select a phase, it shows the activity dropdown, but if you click away from the dropdown, it autoselects the first option, which is the first issue, and the second issue is that it doesn't recognise it is selected.

If you select another option or select it properly, it works. I know these errors were here before, but since we are making the activity dropdown required if the task phase is selected, it means we will have to fix them.

Screenshot 2024-11-04 at 1 37 20 PM

@caleballdrin caleballdrin requested a review from dr-bizz November 4, 2024 20:18
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still does it somewhat. If you get to the activity and then press the downward arrow, then click on another field, it selects the item you were on, then doesn't allow the user to continue.
Screenshot 2024-11-04 at 4 35 09 PM

@caleballdrin caleballdrin requested a review from dr-bizz November 5, 2024 17:53
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you for fixing this!

@caleballdrin caleballdrin merged commit 01d172b into main Nov 6, 2024
17 of 18 checks passed
@caleballdrin caleballdrin deleted the task-changes branch November 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants