Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8145] Make address street optional #1177

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 5, 2024

Description

Allow the address street to be ommitted. Users may know the city and state of a contact but not their street address. However, we do require that at least one of the address text fields be entered.

Testing

  • Create a new address
    • Check that the save button is disabled
    • Type in a field that isn't the street (i.e. the city)
    • Save the address and check that it saved successfully
  • Edit the existing address you just created
    • Clear the single field with a value
    • Check that the save button is disabled because all fields are empty
    • Type in a different field that isn't the street (i.e. the state)
    • Save the address and check that it updated successfully

MPDX-8415

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 5, 2024
@canac canac requested a review from dr-bizz November 5, 2024 19:33
@canac canac self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Preview branch generated at https://8145-optional-street-address.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Bundle sizes [mpdx-react]

Compared against 8031fd4

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@canac canac merged commit fd125c5 into main Nov 6, 2024
19 checks passed
@canac canac deleted the 8145-optional-street-address branch November 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants