[HS-1251563] Sort and refresh contact tags #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://hs-1251563-tags-issues.d3dytjb8adxkk5.amplifyapp.com |
canac
commented
Nov 5, 2024
| page === 'contacts' ? ContactFiltersDocument : TaskFiltersDocument, | ||
| variables: { accountListId }, | ||
| }, | ||
| page === 'contacts' ? ContactFiltersDocument : TaskFiltersDocument, |
There was a problem hiding this comment.
For some reason, how this was wasn't causing the data to refresh. Removing the variables makes it work though.
There was a problem hiding this comment.
I wonder if it saw it as a different query
Bundle sizes [mpdx-react]Compared against 5bd236b
|
dr-bizz
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
The code looks great. I'm a little bit confused with this message: https://secure.helpscout.net/conversation/2749833892/1251563/
Why do you need to refetch the whole contact list when you can just refetch the filters?
| page === 'contacts' ? ContactFiltersDocument : TaskFiltersDocument, | ||
| variables: { accountListId }, | ||
| }, | ||
| page === 'contacts' ? ContactFiltersDocument : TaskFiltersDocument, |
There was a problem hiding this comment.
I wonder if it saw it as a different query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://secure.helpscout.net/conversation/2749833892/1251563/
Checklist: