[no-Jira] Upgrade i18next-parser #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against 09e40fd No significant changes found |
dr-bizz
requested changes
Nov 11, 2024
@dr-bizz Can you give me filenames and line numbers? I don't see |
dr-bizz
approved these changes
Nov 11, 2024
3 tasks
Fixes a vulnerability in vue-template-compiler.
* Replace useKeysAsDefaultValue with a defaultValue function. * Documentation: https://github.com/i18next/i18next-parser/blob/master/docs/migration.md#migrating-from-6x-to-7x * Remove nsSeparator because it was never a valid config field.
canac
force-pushed
the
dependabot-i18next-parser
branch
from
da4d33d to
6212376
Compare
|
Preview branch generated at https://dependabot-i18next-parser.d3dytjb8adxkk5.amplifyapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
i18next-parserto fix a vulnerability invue-template-compiler. Also, runyarn extractto verify that the output is the same with the old version and the new version.Testing
The
Run yarn extractcommit was made with the old version as a reference point. To verify that the the new version produces the same output, rungit restore public/locales/en/translation.json --source=mainto revert that file back to its contents onmain. Then runyarn extractand verify that there are no uncommitted changes. Without the changes to the config file, v9 produces empty strings for the values of any new labels it finds.Checklist: