-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8442] Localize more labels #1193
Conversation
Preview branch generated at https://8442-localize-labels.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against d7a008e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for improving MPDX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should consoladate the useLocations hooks, so we have one? It means there will be less to maintain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The location options for email addresses and phone numbers are similar but different. That's why I have two files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of passing in a value of email
or phone
so that you get the correct locations back, so you only have to maintain one file. It's not a biggy, so I won't die on the hill.
...ntacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonEmail/useLocations.ts
Outdated
Show resolved
Hide resolved
...ancialAccountsReport/AccountTransactions/AccountTransactionTable/AccountTransactionTable.tsx
Outdated
Show resolved
Hide resolved
src/components/Shared/CollapsibleContactInfo/CollapsibleEmailList.tsx
Outdated
Show resolved
Hide resolved
src/components/Shared/CollapsibleContactInfo/CollapsiblePhoneList.tsx
Outdated
Show resolved
Hide resolved
The list of default Data Grid labels are defined here: https://github.com/mui/mui-x/blob/v5.17.4/packages/grid/x-data-grid/src/constants/localeTextConstants.ts. I copy/pasted them and converted each one to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the translations for the table and DataGrid and putting the locations hooks in the global hooks folder.
Could you also run extract
and upload the new phrases to OneSky so Scott can work on translating them?
9dcc2e2
to
ea4b566
Compare
@dr-bizz Thanks for the reminder and for the code review feedback! |
Description
Localize nearly all of the labels reported by Scott in the screenshots here: https://secure.helpscout.net/conversation/2761067138/1258312
The impersonation message doesn't appear to be translated yet in OneSkey, so that one isn't fixed in this PR. The action filters need to be localized by the server, so that one isn't fixed in this PR either.
@dr-bizz Any chance you remember why the "All Tasks" label was explicitly not localized before? I removed that logic, but let me know if there's a reason to keep it.
MPDX-8442
Checklist: