Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HS-1258682 Appeals Loading Fix #1195

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

caleballdrin
Copy link
Contributor

Description

https://secure.helpscout.net/conversation/2761477377/1258682?folderId=7669074
Users with over 50 appeals were not able to see their appeals because Apollo was not merging the results from useFetchAllPages back into the result from the initial query.
Fix: Set the field policy of the field appeals to paginationFieldPolicy

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Nov 15, 2024
@caleballdrin caleballdrin requested a review from canac November 15, 2024 03:37
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against c0745fa

No significant changes found

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 15, 2024
Copy link
Contributor

Preview branch generated at https://hs-1258682-appeals-loading.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this one out!

@caleballdrin caleballdrin merged commit 95a5eae into main Nov 15, 2024
19 checks passed
@caleballdrin caleballdrin deleted the hs-1258682-appeals-loading branch November 15, 2024 15:02
@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 15, 2024

@caleballdrin I think this is causing an error on the appeal page when you switch from account list to account list.

canac pushed a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants