Appeals - Remove appeals when switch account list #1196
Conversation
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://fix-appeal-not-changing-on-account-switch.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 95a5eae No significant changes found |
|
Great! |
| </Box> | ||
| ))} | ||
| </> | ||
| data.regularAppeals.nodes.map((appeal) => ( |
There was a problem hiding this comment.
@dr-bizz Do you know why moving it outside of the fragment changes things?
There was a problem hiding this comment.
The issue was the key. At first, it was the appeal's name, which sometimes had duplicates. I switched it to the id, which would be unique.
I don't think removing the fragment did anything apart from simplifying the code (in my opinion). Maybe React read the Fragment as an item and kept it in the render, but that is unlikely.
There was a problem hiding this comment.
Gotcha. I missed that the key changed. That's probably what fixed it.
Description
Ensure React keeps track of the appeals, to ensure they are removed correctly when the user switches account.
Checklist: