Fixing issue with error when deleting contact from appeal. #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On appeals, when deleting a contact from an appeal, it would sometimes error. This PR fixes this bug.
The issue arose as I added functionality that tested the contact in question is on the appeal. However, since it meant we had to load all the contacts before we deleted it, if the user clicks the "Remove" button before it all loads, it would cause this error.
I could have prevented the "Remove" button from being selected until all contacts were loaded or removed the functionality and let the server check and produce the error. I opted to remove it as it adds a better UX, and as a bonus, there's less code to manage.
Checklist: