-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appeals - Add warning and tooltip to Received title and pledge status dropdown #1203
Conversation
Preview branch generated at https://hs-1260229.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against a1efd19 No significant changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me wants to disable dragging to the Received column too, but that might be going too far.
src/components/Tool/Appeal/Flow/ContactFlowColumn/ContactFlowColumn.tsx
Outdated
Show resolved
Hide resolved
if (expectToFindWarnings) { | ||
// eslint-disable-next-line jest/no-conditional-expect | ||
expect(queryByTestId('received-warnings')).toBeInTheDocument(); | ||
} else { | ||
// eslint-disable-next-line jest/no-conditional-expect | ||
expect(queryByTestId('received-warnings')).not.toBeInTheDocument(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (expectToFindWarnings) { | |
// eslint-disable-next-line jest/no-conditional-expect | |
expect(queryByTestId('received-warnings')).toBeInTheDocument(); | |
} else { | |
// eslint-disable-next-line jest/no-conditional-expect | |
expect(queryByTestId('received-warnings')).not.toBeInTheDocument(); | |
} | |
const warning = queryByTestId('received-warnings'); | |
if (expectToFindWarnings) { | |
// eslint-disable-next-line jest/no-conditional-expect | |
expect(warning).toBeInTheDocument(); | |
} else { | |
// eslint-disable-next-line jest/no-conditional-expect | |
expect(warning).not.toBeInTheDocument(); | |
} |
I have discussed this with Scott, and that is the direction we want to take. However, we decided to just make this change for now and make that change later. |
Description
A lot of users have complained about the Received column and how it is confusing. In this PR, I'm adding a warning message that informs users not to select the Received status and adding a tooltip to the Received flows column title.
Helpscout: https://secure.helpscout.net/conversation/2764260250/1260229?folderId=7296147
Test:
Checklist: