Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appeals - Add warning and tooltip to Received title and pledge status dropdown #1203

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 18, 2024

Description

A lot of users have complained about the Received column and how it is confusing. In this PR, I'm adding a warning message that informs users not to select the Received status and adding a tooltip to the Received flows column title.

Helpscout: https://secure.helpscout.net/conversation/2764260250/1260229?folderId=7296147

Test:

  1. Create an appeal and assign contacts to it.
  2. Create a pledge; when you set the status to "Received", the warnings will show.
  3. Edit a pledge which is "Committed", then set the status to "Received". This will show the warnings.
  4. Edit a pledge which is "Received". the warnings will not show.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Nov 18, 2024
@dr-bizz dr-bizz requested a review from canac November 18, 2024 20:46
Copy link
Contributor

Preview branch generated at https://hs-1260229.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Bundle sizes [mpdx-react]

Compared against a1efd19

No significant changes found

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me wants to disable dragging to the Received column too, but that might be going too far.

Comment on lines 468 to 475
if (expectToFindWarnings) {
// eslint-disable-next-line jest/no-conditional-expect
expect(queryByTestId('received-warnings')).toBeInTheDocument();
} else {
// eslint-disable-next-line jest/no-conditional-expect
expect(queryByTestId('received-warnings')).not.toBeInTheDocument();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (expectToFindWarnings) {
// eslint-disable-next-line jest/no-conditional-expect
expect(queryByTestId('received-warnings')).toBeInTheDocument();
} else {
// eslint-disable-next-line jest/no-conditional-expect
expect(queryByTestId('received-warnings')).not.toBeInTheDocument();
}
const warning = queryByTestId('received-warnings');
if (expectToFindWarnings) {
// eslint-disable-next-line jest/no-conditional-expect
expect(warning).toBeInTheDocument();
} else {
// eslint-disable-next-line jest/no-conditional-expect
expect(warning).not.toBeInTheDocument();
}

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 18, 2024

Part of me wants to disable dragging to the Received column too, but that might be going too far.

I have discussed this with Scott, and that is the direction we want to take. However, we decided to just make this change for now and make that change later.

@dr-bizz dr-bizz enabled auto-merge November 18, 2024 22:10
@dr-bizz dr-bizz merged commit e5e950c into main Nov 18, 2024
18 checks passed
@dr-bizz dr-bizz deleted the hs-1260229 branch November 18, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants