[MPDX-8445] NextJS v13 upgrade #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* @mui/material, @mui/icons-material, and lodash are optimized by default https://nextjs.org/docs/13/app/api-reference/next-config-js/optimizePackageImports * Fix webpack rule matcher
|
Preview branch generated at https://8445-nextjs-13-upgrade.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against e5e950c
|
dr-bizz
reviewed
Nov 20, 2024
src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx
Outdated
Show resolved
Hide resolved
src/components/Dashboard/ThisWeek/LateCommitments/LateCommitments.tsx
Outdated
Show resolved
Hide resolved
src/components/Layouts/Primary/TopBar/Items/SearchMenu/SearchDialog.tsx
Outdated
Show resolved
Hide resolved
dr-bizz
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
This is looking good. I have a few comments, but no big changes. I will approve so you are not blocked.
Do you also want to change pages/accountLists/[accountListId]/contacts/[[...contactId]].page.tsx title to match how you have done the titles on other pages? I'm not too fussed about it
<title>
{appName} |{' '}
{viewMode === TableViewModeEnum.Flows
? t('Contact Flows')
: viewMode === TableViewModeEnum.Map
? t('Contacts Map')
: t('Contacts')}
</title>
```
NextJS automatically loads .env files into process.env
Fixes "Warning: A title element received an array with more than 1 element as children."
canac
force-pushed
the
8445-nextjs-13-upgrade
branch
from
4c97ea1 to
6087e61
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to NextJS v13. The main change was changing all of our
next/linkcomponents (migration guide). Links now create anaelement instead of needing to have a single child that is anaelement. In the future we no longer have to usepassHreforlegacyBehavior(and we should not use either of those props in the future).Other changes
next.config.jsfile and fixed warnings about environment variables being undefined.next-image-loaderwebpack rule.experimental.modularizeImportsconfiguration (https://nextjs.org/docs/13/app/api-reference/next-config-js/optimizePackageImports).dotenvbecause NextJS already supports automatically loading.envfiles (https://nextjs.org/docs/13/app/building-your-application/configuring/environment-variables).<title>elements to use string interpolation instead of JSX expressions. This fixes theWarning: A title element received an array with more than 1 element as children.warnings and fixes tab titles briefly containing<!-- -->.Amplify config changes
NODE_ENVenvironment variable. Setting it todevelopmentcaused build errors, and the Next.js docs advise against this. It is automatically set toproductionby Next.js when runningyarn build, so we don't need to manually set it.package.json.MPDX-8445
Checklist: