-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8445] Next.js v15 upgrade #1212
Conversation
Bundle sizes [mpdx-react]Compared against 51a722f
|
Preview branch generated at https://8445-nextjs-15-upgrade.d3dytjb8adxkk5.amplifyapp.com |
e78d950
to
9d00bc4
Compare
It started defaulting to true in Next.js 13 and appears to have been removed in Next.js 15 https://nextjs.org/docs/pages/building-your-application/upgrading/version-13#v13-summary
The env property now accepts undefined values, so compact is no longer needed.
dc3eef6
to
4cb39e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It mentions that fetch requests are not cached by default. I know we don't use fetch much and might not need to add caching but thought it was worth noting.
The code and the web ap look great.
Also it looks like swcMinify
is allowed in Next.js 15 - https://nextjs.org/docs/messages/swc-minify-enabled
@dr-bizz The only places I saw that we were making
That link is just additional info for an error message generated by older Next.js versions. Here's the PR that removed |
Description
Upgrade to Next.js v15. There are lots of breaking changes in the v15 release but not in features that we are using: https://nextjs.org/docs/app/building-your-application/upgrading/version-15.
I only needed to remove the
swcMinify
config option that started defaulting to true in Next.js 13 and was removed in Next.js 15.I also migrated
next.config.js
tonext.config.ts
now that Next.js supports TypeScript config files.MPDX-8445
Checklist: