Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Give bundle-analyzer permission to comment on dependabot PRs #1213

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 25, 2024

Description

Currently, Dependabot PRs fail in the bundle-analzyer step because the default GitHub token doesn't have permission to create a comment on the PR (example run). It appears that the fix is to give additional permissions to that workflow step (docs).

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 25, 2024
@canac canac requested a review from dr-bizz November 25, 2024 15:36
@canac canac self-assigned this Nov 25, 2024
Copy link
Contributor

Preview branch generated at https://dependabot-bundle-analyzer.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 5d87e66

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this

.github/workflows/ci.yml Show resolved Hide resolved
@canac canac requested a review from dr-bizz November 25, 2024 20:22
@canac canac merged commit 34edc48 into main Nov 25, 2024
19 checks passed
@canac canac deleted the dependabot-bundle-analyzer branch November 25, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants