Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to remove next increase ask date #1220

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Dec 11, 2024

Description

In this PR, I allow the user to remove the Next Increase Ask date. A Help Scout ticket brought this to my attention.
I also noticed this was happening to the Start Date field, which I fixed.

When adding tests, I cleaned up the page.

To Test:

  1. On a contact, click on the Donations tab, scroll down and then click on the Partnership info tab.
  2. Edit partnership to show modal.
  3. Set a Next Increase Ask date if there isn't one.
  4. On the Next Increase Ask field, click the calendar icon, and then click CLEAR.
  5. Click Save

On production, doing the above will not remove the Next Increase Ask date.
On the preview link, the Next Increase Ask date will be removed.

HelpScout Ticket
Jira Task

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz force-pushed the allow-user-to-remove-next-increase-ask-date branch from dbd1aa1 to ed9c28f Compare December 11, 2024 12:28
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Dec 11, 2024
@dr-bizz dr-bizz requested a review from canac December 11, 2024 12:28
Copy link
Contributor

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against dbfb393

No significant changes found

@dr-bizz dr-bizz requested review from caleballdrin and removed request for canac December 11, 2024 13:35
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it works! Thanks for the fix.

@dr-bizz dr-bizz force-pushed the allow-user-to-remove-next-increase-ask-date branch from ed9c28f to f68ad47 Compare December 11, 2024 19:58
@dr-bizz dr-bizz enabled auto-merge December 11, 2024 19:58
@dr-bizz dr-bizz merged commit 321d8db into main Dec 11, 2024
17 checks passed
@dr-bizz dr-bizz deleted the allow-user-to-remove-next-increase-ask-date branch December 11, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants