MPDX-8491 - Fix Activity Type Case-Sensitivity Issue in Google Calendar Integration #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when we pass the data to the API since we get the data in lowercase.
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://hs-1252356-add-org-edit.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 0c76edd No significant changes found |
caleballdrin
approved these changes
Dec 12, 2024
|
Were you able to get it to work on staging? If so, something is wrong here. Otherwise it might just be a staging thing |
|
I retested this in staging to ensure my code changes were working. On staging, I wasn't seeing my tasks events in my calendar either, so I know my code is working. We might need to ask a backend dev if they know why the Google integration isn't working on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where activity types were not being correctly updated in the Google Calendar integration. The root cause was identified in the handling of a proxy GraphQL query used to fetch the current calendar integration. During this process, lowercase values were converted to uppercase to align with the rest of the website's standards.
However, when sending the calendar integrations back to the REST API, the values needed to be reverted to lowercase. This discrepancy caused issues since the API correctly treats
APPOINTMENT_PHONE_CALLandappointment_phone_callas distinct values. This fix ensures proper conversion and resolves the integration issue.Jira Task
HelpScout Ticket
Checklist: