MPDX-8496 - Replace hard coded emails with env variables #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://add-donor-services-email-env.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against eaf5e36 No significant changes found |
canac
reviewed
Dec 13, 2024
...nents/Contacts/ContactDetails/ContactDetailsHeader/DeleteContactModal/DeleteContactModal.tsx
Outdated
Show resolved
Hide resolved
canac
reviewed
Dec 13, 2024
...nents/Contacts/ContactDetails/ContactDetailsHeader/DeleteContactModal/DeleteContactModal.tsx
Outdated
Show resolved
Hide resolved
...nents/Contacts/ContactDetails/ContactDetailsHeader/DeleteContactModal/DeleteContactModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Settings/Organization/Contacts/ContactRow/ContactRow.tsx
Outdated
Show resolved
Hide resolved
|
I have used the donor account IDs as I couldn't find the partner account ID you mentioned. |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
canac
reviewed
Dec 17, 2024
| @@ -1,6 +1,16 @@ | |||
| query ContactSource($accountListId: ID!, $contactId: ID!) { | |||
| query Contact($accountListId: ID!, $contactId: ID!) { | |||
There was a problem hiding this comment.
Why the rename? Honestly ContactSource seems like a more descriptive name for this operation.
There was a problem hiding this comment.
⬆️ @dr-bizz Did you see this comment?
There was a problem hiding this comment.
I changed it because we're getting more info than just the contactSource, we're now getting all the people on the contact
canac
reviewed
Dec 17, 2024
...nents/Contacts/ContactDetails/ContactDetailsHeader/DeleteContactModal/DeleteContactModal.tsx
Show resolved
Hide resolved
canac
reviewed
Dec 17, 2024
...nents/Contacts/ContactDetails/ContactDetailsHeader/DeleteContactModal/DeleteContactModal.tsx
Outdated
Show resolved
Hide resolved
canac
approved these changes
Dec 17, 2024
dr-bizz
force-pushed
the
add-donor-services-email-env
branch
from
ab74387 to
1f91215
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all hardcoded emails from MPDX and replace them with variables so non-Cru organisations can use their emails without editing the source code.
We don't need to add any new variables to our Amplify as the default values are the ones we use.
This was spotted on Jira task MPDX-8492 and PR #1216
Checklist: