Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HS-1262665] Fix addresses with zip codes not showing predictions #1233

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 18, 2024

Description

Disable the default filtering of options in the address autocomplete. Typing an address with a zip code wasn't bringing up any results because the predictions from the Google Maps API don't show the zip code in the description. This will also let users select predictions that don't strictly contain the search substring.

Testing

  • In production, create a new address and paste "100 Lake Hart Dr, Orlando, FL 32832" into the street search. See that there are not options listed.
  • In this preview environment, create a new address and paste "100 Lake Hart Dr, Orlando, FL 32832" into the street search. See that there is an option listed.

https://secure.helpscout.net/conversation/2769079534/1262665?viewId=7296729

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Dec 18, 2024
@canac canac requested a review from dr-bizz December 18, 2024 21:53
@canac canac self-assigned this Dec 18, 2024
Copy link
Contributor

Preview branch generated at https://hs-1262665-match-zip-code.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 7e667dd

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want the postal additional code to show in the zip code?

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if the user enter's 334 hoofbeat Trail Northest, Kennesaw, GA, 30144-1618 it still auto-completes the address, which I think it fine. The user can add the additional postal code -1618 if nedded.

@canac
Copy link
Contributor Author

canac commented Dec 19, 2024

Do we also want the postal additional code to show in the zip code?

@dr-bizz My thought is yes since addresses from Donation Services have the extra 4 digits in the zip code. But I was going to wait to hear back from Scott before making that change.

@canac canac merged commit eaf5e36 into main Dec 19, 2024
20 checks passed
@canac canac deleted the hs-1262665-match-zip-code branch December 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants