MPDX-8506 - Prevent hydration errors being sent to RollBar #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against e2bbe01 No significant changes found |
canac
approved these changes
Dec 19, 2024
| enabled: !!process.env.ROLLBAR_ACCESS_TOKEN, | ||
| enabled: Boolean(process.env.ROLLBAR_ACCESS_TOKEN), | ||
| checkIgnore: (_, args) => | ||
| [ |
There was a problem hiding this comment.
Suggested change
| [ | |
| // Ignore React hydration warnings | |
| [ |
dr-bizz
force-pushed
the
prevent-dehydration-logs
branch
2 times, most recently
from
fb4cb7f to
9d2cdc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the amount of errors being sent to RollBar regarding hydration and it maxing out our log rate limit, we need to prevent them from being sent to Rollbar.
In this PR, I add a check to prevent any logs regarding hydration from being sent to Rollbar.
We might just be able to get away with ignoring
Minified React errorand not have to worry aboutExpected server HTMLsince that only shows locally.Checklist: