Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Remove unused packages #1244

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[no-Jira] Remove unused packages #1244

wants to merge 3 commits into from

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 20, 2024

Description

Out of curiosity I ran depcheck and found some unused packages.

I moved isomorphic-fetch to devDependencies because it is only used in test code.

I also moved prop-types to dependencies because it is a required peer dependency of @rollbar/react.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Dec 20, 2024
@canac canac self-assigned this Dec 20, 2024
Copy link
Contributor

Preview branch generated at https://remove-unused-packages.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Bundle sizes [mpdx-react]

Compared against 51365b4

No significant changes found

@canac canac force-pushed the remove-unused-packages branch from b4acf0e to b6ce88a Compare December 20, 2024 18:37
@canac canac requested a review from dr-bizz December 20, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant