Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-7717] Prevent contact details drawer from overlapping task list #768

Closed
wants to merge 2 commits into from

Conversation

canac
Copy link
Contributor

@canac canac commented May 24, 2023

Shrink the task list when the contact details drawer is open so that all data is still visible.

https://jira.cru.org/browse/MPDX-7717

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label May 24, 2023
@canac canac requested a review from dr-bizz May 24, 2023 20:04
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-768.d1gea2s40al8l0.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I did see a issue on mobile but everything else looked good.

loading={loading}
data={data?.tasks.nodes}
style={{
height: `calc(100vh - ${navBarHeight} - ${headerHeight} - ${buttonBarHeight})`,
width: contactDetailsOpen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When on smaller devices you can't select other tasks as they're covered up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I just met with Scott in a call, and he said that we should hold off on this until some more design works happens to figure out what to display on smaller screens.

@canac canac marked this pull request as draft May 26, 2023 15:36
@canac canac closed this Dec 6, 2024
@canac canac deleted the 7717-task-contact-panel branch December 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants