Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7774 - Appeal on Dashboard needs a link to that appeal #800

Merged
merged 3 commits into from
Nov 1, 2023
Merged

MPDX-7774 - Appeal on Dashboard needs a link to that appeal #800

merged 3 commits into from
Nov 1, 2023

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 24, 2023

Description

The appeal on the Dashboard needs a link to that appeal

Changes

  • Made the appeal clickable

@dr-bizz dr-bizz requested a review from caleballdrin October 24, 2023 19:22
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Oct 24, 2023
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-800.d3dytjb8adxkk5.amplifyapp.com

caleballdrin
caleballdrin requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a little cluttered with the link having an underline. Could you change it to have the underline only show when someone hovers over it? I think that is the way it is on the old version.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Oct 25, 2023

@caleballdrin Great catch! I also reworked the styles to use the makeStyles() which was already on the page.

@dr-bizz dr-bizz requested a review from caleballdrin October 25, 2023 13:55
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Oct 25, 2023

The error with AWS Amplify Console Web Preview was that it failed to install node v16 during the build phase.

@dr-bizz dr-bizz merged commit b90f2b4 into main Nov 1, 2023
@dr-bizz dr-bizz deleted the MPDX-7774-appeal-link branch November 1, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bizz @caleballdrin