Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Upgrade to Node v18 follow-up #801

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[no-Jira] Upgrade to Node v18 follow-up #801

merged 1 commit into from
Oct 30, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 30, 2023

Follow up to #798.

  • I use nvm to manage my local versions, so this PR bumps the Node version in .nvmrc.
  • Also, I saw job in GHA that was still using Node v16, so I fixed that as well. @dr-bizz Let me know if that job needed to stay on v16.
  • Lastly, I updated the documentation to say that we use Node v18.

@canac canac requested a review from dr-bizz October 30, 2023 14:53
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-801.d3dytjb8adxkk5.amplifyapp.com

dr-bizz
dr-bizz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for finding these!

@canac canac merged commit 58ed1a8 into main Oct 30, 2023
14 checks passed
@canac canac deleted the node-18 branch October 30, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz