Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-7800] Fix monthly activity graph #804

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 31, 2023

Populate the coaching report monthly activity graph by changing the query to load the coaching account list instead of trying to load the user's account list.

https://jira.cru.org/browse/MPDX-7800

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Oct 31, 2023
@canac canac requested review from caleballdrin and dr-bizz October 31, 2023 19:09
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-804.d3dytjb8adxkk5.amplifyapp.com

@canac
Copy link
Contributor Author

canac commented Oct 31, 2023

Tested in staging ✅

@canac canac force-pushed the 7800-monthly-activity-graph branch from 9aa3774 to f1fa09a Compare November 2, 2023 19:15
@canac canac requested a review from dr-bizz November 2, 2023 19:17
@canac
Copy link
Contributor Author

canac commented Nov 2, 2023

@dr-bizz I moved the data loading outside of MonthlyActivitySection like you suggested. As a result, <MonthlyActivitySection> didn't do anything anymore, so I was able to remove it and move its tests into DonationsReport.test.tsx.

@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 2, 2023

I'll review this tomorrow morning

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little hard to test as I couldn't find an account which I'm coaching and has donations . but the code looked good.

@canac canac merged commit efe00c5 into main Nov 3, 2023
14 of 15 checks passed
@canac canac deleted the 7800-monthly-activity-graph branch November 3, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants