Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving component NavReportsList to shared folder and adding new Preferences types #817

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 9, 2023

Description

We have done a lot of work on Preferences. To prevent a 100-plus page PR I'm pushing certain changes into main which doesn't affect the user.

These changes are to the NavReportsList Component. I've changed how Reports use this repo by moving it's location to the Shared folder and prepping it with Preferences TS types.

Changes

  • Moved the NavReportsList components to the Shared folder
  • Updated all pages and components that used NavReportsList.
  • Added types which we will use for the Preferences.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested review from canac and caleballdrin November 9, 2023 19:39
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-817.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea on re-using the navigation menu MultiPageMenu for both Reports and Settings. Looks good from what I can tell.

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting out these changes from the main UI! Can you advise which places to test in the UI to make sure that everything is still working?

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 10, 2023

@canac These changes affect the side menu on all the Report pages. Most have a side menu, however, some like Partner Giving Analysis do not.

@dr-bizz dr-bizz requested a review from canac November 10, 2023 14:25
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Nov 10, 2023
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work locally!

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 13, 2023

I have merged this into staging locally and fixed the merge conflicts

@dr-bizz dr-bizz merged commit fb2c88a into main Nov 13, 2023
15 checks passed
@dr-bizz dr-bizz deleted the multi-page-header branch November 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants