Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-7212] Add appointment results table #819

Merged
merged 20 commits into from
Nov 29, 2023
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 10, 2023

Description

Implement the Appointments and Results table in the coaching section. I recommend testing by going to the coaching page for Clark Kent because he has data in his report for November. The URL is https://next-stage.mpdx.org/accountLists/${your-account-list-id}/coaching/0587c86d-3b8a-4c42-8394-8f63007fdd1e.

https://jira.cru.org/browse/MPDX-7212

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Nov 10, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-819.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but nothing crazy. Looks goods

@canac canac requested a review from dr-bizz November 13, 2023 15:37
@canac canac requested a review from dr-bizz November 17, 2023 20:38
@canac
Copy link
Contributor Author

canac commented Nov 17, 2023

@dr-bizz Can you review the new changes from this commit when you get a chance? Before, when you resize the window to be wider, the chart would expand, but then when you resize the window to be narrower, the chart would still keep it's large size. The calc should fix that.

The sidebar should possibly be hidden on really small screens like mobile, but I need to see what Scott thinks because that information seems important to show somewhere.

@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 20, 2023

Will review now

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, I think it would work better if the left-hand side was collapsible, as I'm unsure if the information on the left-side menu is always important to the user.
Screenshot 2023-11-20 at 11 29 24 AM

The graph containers go off the page, If you were trying to do what I was referring to last week, I was speaking of making the graph containers fit into the width, but the actual graphs be wider and allowing the user to scroll left-to-right inside the container.
Screenshot 2023-11-20 at 11 47 24 AM

<CardHeader
className={classes.cardHeader}
title={
<Box display={{ xs: 'none', sm: 'block' }}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this <Box> wrapper because it only exists for display breakpoints that are already present on its parent.

@dr-bizz dr-bizz self-requested a review November 29, 2023 20:24
@canac canac merged commit a9d935d into main Nov 29, 2023
15 checks passed
@canac canac deleted the 7212-appointments-results branch November 29, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants