-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-7212] Add appointment results table #819
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but nothing crazy. Looks goods
src/components/Coaching/CoachingDetail/AppointmentResults/AppointmentResults.tsx
Outdated
Show resolved
Hide resolved
src/components/Coaching/CoachingDetail/AppointmentResults/AppointmentResults.tsx
Outdated
Show resolved
Hide resolved
src/components/Coaching/CoachingDetail/AppointmentResults/AppointmentResults.tsx
Outdated
Show resolved
Hide resolved
@dr-bizz Can you review the new changes from this commit when you get a chance? Before, when you resize the window to be wider, the chart would expand, but then when you resize the window to be narrower, the chart would still keep it's large size. The The sidebar should possibly be hidden on really small screens like mobile, but I need to see what Scott thinks because that information seems important to show somewhere. |
Will review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile, I think it would work better if the left-hand side was collapsible, as I'm unsure if the information on the left-side menu is always important to the user.
The graph containers go off the page, If you were trying to do what I was referring to last week, I was speaking of making the graph containers fit into the width, but the actual graphs be wider and allowing the user to scroll left-to-right inside the container.
<CardHeader | ||
className={classes.cardHeader} | ||
title={ | ||
<Box display={{ xs: 'none', sm: 'block' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this <Box>
wrapper because it only exists for display breakpoints that are already present on its parent.
Description
Implement the Appointments and Results table in the coaching section. I recommend testing by going to the coaching page for Clark Kent because he has data in his report for November. The URL is
https://next-stage.mpdx.org/accountLists/${your-account-list-id}/coaching/0587c86d-3b8a-4c42-8394-8f63007fdd1e
.https://jira.cru.org/browse/MPDX-7212
Checklist: