Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Localize ARIA labels #824

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[no-Jira] Localize ARIA labels #824

merged 2 commits into from
Nov 29, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 21, 2023

Description

Localize all unlocalized ARIA labels in the project.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Nov 21, 2023
@canac canac requested a review from dr-bizz November 21, 2023 15:04
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-824.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this. There are a few you missed:

src/components/Contacts/ContactDetails/ContactDetailsTab/PartnerAccounts/ContactDetailsPartnerAccounts.tsx - line 133

src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/LogNewsletter.tsx - lines 180, 278

src/components/Reports/DonationsReport/Table/Modal/EditDonationModal.tsx - lines 192, 277, 287

src/components/Reports/PartnerGivingAnalysisReport/PartnerGivingAnalysisReport.tsx - lines 187

src/components/Task/MassActions/EditTasks/MassActionsEditTasksModal.tsx - lines 166, 333

src/components/Task/Modal/Comments/Form/TaskModalCommentsListForm.tsx - line 119

src/components/Task/Modal/Comments/Item/TaskModalCommentListItem.tsx - line 127

src/components/Task/Modal/Form/TaskModalForm.tsx - lines 301 357, 739

src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx - line 318

src/components/Task/Modal/Form/LogForm/TaskModalLogForm.tsx - lines 277, 332, 500

@canac
Copy link
Contributor Author

canac commented Nov 22, 2023

@dr-bizz Oops! I missed that pattern in my search.

@canac canac requested a review from dr-bizz November 22, 2023 14:48
@canac
Copy link
Contributor Author

canac commented Nov 28, 2023

@dr-bizz Is this good now?

@canac canac merged commit 220e544 into main Nov 29, 2023
15 checks passed
@canac canac deleted the localize-aria-labels branch November 29, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants