Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-7532] Add coaching weekly report #828

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 29, 2023

Description

Implement coaching weekly report.

https://jira.cru.org/browse/MPDX-7532

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Nov 29, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-828.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It all looks good. You could make the skeletons into a 3-by-3 grid, to more them look like the questions, but most people won't even see that, so I don't know if it's worth while.

@canac
Copy link
Contributor Author

canac commented Dec 4, 2023

@dr-bizz One challenge with the skeletons is that while Cru uses 8 questions, other orgs may use a different number, so it's hard to create a skeleton that looks like an answer set for any org.

@dr-bizz
Copy link
Contributor

dr-bizz commented Dec 4, 2023

@dr-bizz One challenge with the skeletons is that while Cru uses 8 questions, other orgs may use a different number, so it's hard to create a skeleton that looks like an answer set for any org.

That's a good point

@canac canac merged commit 21f91e3 into main Jan 9, 2024
15 checks passed
@canac canac deleted the 7532-coaching-weekly-report branch January 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants