Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-7859] -Adds additional spacing to helpscout beacon. #886

Merged
merged 1 commit into from
May 6, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Mar 4, 2024

Description

Move help beacon left 150 px from right edge. Jira ticket #7859.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added the On Staging Will be merged to the staging branch by Github Actions label Mar 4, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-886.d3dytjb8adxkk5.amplifyapp.com

@wjames111 wjames111 changed the title Adds additional spacing to helpscout beacon. [MPDX-7859] -Adds additional spacing to helpscout beacon. Mar 14, 2024
@wjames111
Copy link
Contributor Author

The Helpscout Beacon looks a little funny 150px from the right. I just bumped it up by 20px so it's slightly out of the way. It does still cover some of the task/contact action buttons though.

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what Scott had in mind with this, but I'm good with this change if he is. Like you said, it still covers some things, but I think that may be inevitable no matter where we place it.

If you merge main into this branch, the preview environment for this PR will start working.

@wjames111
Copy link
Contributor Author

Yeah agreed, Kind of unavoidable without sticking it basically in the center.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine. I think Scott was just throwing out a number when he mentioned 150px. After he QA's it, you're good to deploy.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Bundle Sizes

Compared against 0416fbd

Route: No significant changes found

Dynamic import: None found.

@wjames111 wjames111 force-pushed the 7859-help-beacon-spacing branch from 75f3180 to ded27d0 Compare May 6, 2024 15:08
Copy link
Contributor

github-actions bot commented May 6, 2024

Bundle sizes [mpdx-react]

Compared against 6e336f7

No significant changes found

@wjames111 wjames111 merged commit 3fc96f5 into main May 6, 2024
18 checks passed
@wjames111 wjames111 deleted the 7859-help-beacon-spacing branch May 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants