-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-7859] -Adds additional spacing to helpscout beacon. #886
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
The Helpscout Beacon looks a little funny 150px from the right. I just bumped it up by 20px so it's slightly out of the way. It does still cover some of the task/contact action buttons though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what Scott had in mind with this, but I'm good with this change if he is. Like you said, it still covers some things, but I think that may be inevitable no matter where we place it.
If you merge main
into this branch, the preview environment for this PR will start working.
Yeah agreed, Kind of unavoidable without sticking it basically in the center. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine. I think Scott was just throwing out a number when he mentioned 150px. After he QA's it, you're good to deploy.
Bundle SizesCompared against 0416fbd Route: No significant changes found Dynamic import: None found. |
75f3180
to
ded27d0
Compare
Bundle sizes [mpdx-react]Compared against 6e336f7 No significant changes found |
Description
Move help beacon left 150 px from right edge. Jira ticket #7859.
Checklist: