MPDX-7829 Ministries Have Self Service MPDX Donor/Account Removal Capability #887

caleballdrin · 2024-03-07T00:56:52Z

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-7829#
KR3: Ministries Have Self Service MPDX Donor/Account Removal Capability

Added Delete Account List, Delete User, and Remove User buttons
Added confirmation message to ask for the reason
Added new anonymize mutation for all contacts
Improved styling of the pages

Checklist:

I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
I have requested a review from another person on the project

…ccount-removal

aws-amplify-us-east-1 · 2024-03-07T01:09:08Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-887.d3dytjb8adxkk5.amplifyapp.com

canac

I only looked at the code, I still need to try running it.

pages/accountLists/[accountListId]/settings/organizations/accountLists.page.tsx

...ttings/Organizations/SearchOrganizationsAccountLists/SearchOrganizationsAccountLists.graphql

src/components/InfiniteList/InfiniteList.tsx

...ion/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.test.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.tsx

src/components/common/Modal/Confirmation/Confirmation.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.tsx

...nization/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.tsx

src/components/Settings/Organization/Contacts/Contacts.tsx

canac · 2024-03-08T17:08:46Z

@caleballdrin Do you know why the background of the delete invite modal is darker than the background of the delete coach modal? I wonder if the delete invite modal is opening two modals on top of each other or something like that.

caleballdrin · 2024-03-08T21:53:17Z

@caleballdrin Do you know why the background of the delete invite modal is darker than the background of the delete coach modal? I wonder if the delete invite modal is opening two modals on top of each other or something like that.

@canac Yes that was the issue. I just fixed it.

pages/accountLists/[accountListId]/settings/organizations/accountLists.page.tsx

src/components/Settings/Organization/Contacts/Contacts.tsx

dr-bizz

Great work on this. I left some comments throughout the code.

src/components/Settings/Organization/Contacts/Contacts.test.tsx

src/components/Settings/Organization/Contacts/Contact.graphql

src/components/Settings/Organization/Contacts/ContactRow/ContactRow.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.test.tsx

...nization/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.tsx

...ion/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.test.tsx

This reverts commit 4837441.

github-actions · 2024-06-06T20:11:40Z

Preview branch generated at https://account-removal.d3dytjb8adxkk5.amplifyapp.com

…nization

dr-bizz

Great work on this! I left some comments and questions on this, but nothing crazy. Great work.

pages/accountLists/[accountListId]/settings/organizations/accountLists.page.tsx

pages/api/Schema/Settings/Organizations/SearchOrganizationsAccountLists/datahandler.ts

src/components/InfiniteList/InfiniteList.tsx

src/components/common/Modal/Confirmation/Confirmation.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.tsx

src/components/Settings/Organization/AccountLists/AccountListRow/AccountListRow.test.tsx

fixed

caleballdrin added 9 commits March 1, 2024 12:53

Set accountLists organization search from local storage

5594ccf

Get userId and lastSyncedAt from searchOrganizationsAccountLists

2270b75

Add textfield functionality to Confirmation modal

4aaf01e

Allow disableHover on infinitelist

18e1178

Add removeUser, deleteUser and deleteAccountList functionality

ab188c1

Refactor confirm dialog state

fac0802

Add tooltip and search instructions

2e0706a

Adjust admin contact list formatting, tooltip and instructions

33b1c5f

Merge branch 'main' of https://github.com/CruGlobal/mpdx-react into a…

8c33c7c

…ccount-removal

caleballdrin self-assigned this Mar 7, 2024

caleballdrin requested review from canac and dr-bizz March 7, 2024 00:57

caleballdrin added 2 commits March 6, 2024 16:59

Add new anonymize mutation and confirmation dialog

c248328

Fix tests

8447b10

Fix tests

230cebf

canac reviewed Mar 7, 2024

View reviewed changes

caleballdrin commented Mar 8, 2024

View reviewed changes

...nization/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.tsx Outdated Show resolved Hide resolved

canac reviewed Mar 8, 2024

View reviewed changes

...nization/AccountLists/AccountListRow/AccountListCoachesOrUsers/AccountListCoachesOrUsers.tsx Show resolved Hide resolved

canac reviewed Mar 8, 2024

View reviewed changes

src/components/Settings/Organization/Contacts/Contacts.tsx Outdated Show resolved Hide resolved

caleballdrin added 4 commits March 8, 2024 13:59

Memoize the selectedOrg and make PR changes

234ee38

Refactor confirm dialog

5563486

Change Confirm dialog props

ea2d32e

Adjust contact spacing

2fbd921

dr-bizz reviewed Mar 11, 2024

View reviewed changes

pages/accountLists/[accountListId]/settings/organizations/accountLists.page.tsx Outdated Show resolved Hide resolved

dr-bizz reviewed Mar 11, 2024

View reviewed changes

src/components/Settings/Organization/Contacts/Contacts.tsx Outdated Show resolved Hide resolved

dr-bizz reviewed Mar 11, 2024

View reviewed changes

src/components/Settings/Organization/Contacts/Contacts.tsx Show resolved Hide resolved

dr-bizz requested changes Mar 11, 2024

View reviewed changes

Fix type

2a5a42b

caleballdrin added the Preview Environment Add this label to create an Amplify Preview label May 1, 2024

wrandall22 added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels May 1, 2024

caleballdrin added 6 commits May 21, 2024 13:37

Change warning message

d9683eb

Fix graphql errors from Task/Phases

4837441

Merge branch 'main' into account-removal

6db838e

Revert "Fix graphql errors from Task/Phases"

28ee8c9

This reverts commit 4837441.

Fix tests and lint errors

f9197f0

Show account list user contact info

2740fdc

caleballdrin added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Jun 6, 2024

Merge branch 'main' into account-removal

506a535

caleballdrin force-pushed the account-removal branch from 284ac12 to 506a535 Compare June 26, 2024 05:54

caleballdrin added 3 commits June 26, 2024 13:28

Dont show delete button if accountList or user is in more than 1 orga…

01fa696

…nization

Add test for user contact info

426bbf9

Merge branch 'main' into account-removal

7b2526e

caleballdrin requested review from dr-bizz and canac August 19, 2024 19:37

Add error state tests

d548c63

dr-bizz requested changes Aug 20, 2024

View reviewed changes

canac removed their request for review August 20, 2024 16:29

Move modals into separate components, review changes

e6281a5

caleballdrin requested a review from dr-bizz August 20, 2024 20:22

Test that contacts, users and coaches are removed

3d17d66

dr-bizz approved these changes Aug 21, 2024

View reviewed changes

caleballdrin merged commit 096efbf into main Aug 21, 2024
18 checks passed

caleballdrin deleted the account-removal branch August 21, 2024 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MPDX-7829 Ministries Have Self Service MPDX Donor/Account Removal Capability #887

MPDX-7829 Ministries Have Self Service MPDX Donor/Account Removal Capability #887

caleballdrin commented Mar 7, 2024 •

edited

Loading

aws-amplify-us-east-1 bot commented Mar 7, 2024

canac left a comment

canac commented Mar 8, 2024

caleballdrin commented Mar 8, 2024 •

edited

Loading

dr-bizz left a comment

github-actions bot commented Jun 6, 2024

dr-bizz left a comment

MPDX-7829 Ministries Have Self Service MPDX Donor/Account Removal Capability #887

MPDX-7829 Ministries Have Self Service MPDX Donor/Account Removal Capability #887

Conversation

caleballdrin commented Mar 7, 2024 • edited Loading

Description

Checklist:

aws-amplify-us-east-1 bot commented Mar 7, 2024

canac left a comment

Choose a reason for hiding this comment

canac commented Mar 8, 2024

caleballdrin commented Mar 8, 2024 • edited Loading

dr-bizz left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 6, 2024

dr-bizz left a comment

Choose a reason for hiding this comment

caleballdrin commented Mar 7, 2024 •

edited

Loading

caleballdrin commented Mar 8, 2024 •

edited

Loading