-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Jira - Allow react to compare component types on render #920
No Jira - Allow react to compare component types on render #920
Conversation
Bundle sizes [mpdx-react]Compared against aad2df0 No significant changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an enum instead of a string, is a great idea! Thanks for making that change!
As I noted in the comments, I don't think that the changes to TaskModal
will improve rendering performance. Although I could definitely be mistaken.
… component types being recreated. Also updating lots of calls to Task Modal
a785e17
to
bb9bc22
Compare
@canac, I had to rebase it to remove your changes from this PR. I've added some of the changes you recommended. I'm keeping the memo function and keeping the Modal content inside the return to keep it consistent with our other Components. |
Description
Preventing React from destroying the component tree on every render due to component types being recreated.
Updated all calls to Task Modal to use the new Enum I created.
I also fixed some imports.
Checklist: