-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-Jira] Run yarn gql:w
alongside the Next.js dev server
#926
Conversation
Bundle sizes [mpdx-react]Compared against dde4508 No significant changes found |
@dr-bizz Sorry for another large PR. The vast majority of the files are yarn packages and generated files, which you should be able to ignore. But let me know if you want me to try to split it up more before you review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. Your changes will make it easier for devs to switch between local branches.
I have left a few comments on how you can split up the changes more to ensure there is only one change per commit.
Can you also split this PR into two? One for updating graphql-codegen
and the related files, and the other for .generated files and other commits. Having two separate PRs will ensure each PR is focused on one Conceptual change per PR.
src/components/Coaching/CoachingDetail/MonthlyCommitment/MonthlyCommitment.test.tsx
Outdated
Show resolved
Hide resolved
0d80faf
to
0dc2785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. I left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good so I'm approving this.
Please can you add the package script I mentioned and add some text to the ReadMe explaining why you need to run gql before pushing.
38cc279
to
dd02443
Compare
yarn gql:w
alongside the Next.js dev server
I switched to a different approach of running |
eslint no longer has to read the generated files only to see the eslint-disable directive at the top and ignore them.
dd02443
to
fd3b016
Compare
I rewrote the bash delete stale files script in node so that it is more readable, maintainable, and robust. Specifically, it will handle filenames containing spaces correctly now. |
Description
.graphql
file was moved, renamed, or deleted. These stale files can cause TS errors and were a significant source of confusion.yarn gql
by not runningprettier
on the generated files.src/graphql/
are not committed because their contents may differ depending on whetheryarn gql
was pointed at the staging or the production API server.git
hook because it is no longer needed.Checklist: