Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HS-1142757 - Organizations links on Settings aren't rendering correctly #930

Merged
merged 4 commits into from
Apr 26, 2024
Merged

HS-1142757 - Organizations links on Settings aren't rendering correctly #930

merged 4 commits into from
Apr 26, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Apr 26, 2024

Description

HelpScout issue
The Organization links are only shown if the user is an admin. However, on the old MPDx, users who weren't admins but managed at least one organization could see the page.

This PR allows users who manage an organization and aren't an admin to view the links and visit the page.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac April 26, 2024 13:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against acbd9f5

No significant changes found

@dr-bizz dr-bizz force-pushed the hs-1142757-manage-organizations-link-not-working branch from aa2785d to 299bea6 Compare April 26, 2024 13:39
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Apr 26, 2024
canac
canac approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I don't think that staging built successfully because it isn't working in staging, but I impersonated the HelpScout user, and it works great locally. I just left a couple of minor questions/suggestions.

src/components/Shared/MultiPageLayout/MultiPageMenu/MultiPageMenu.tsx Show resolved Hide resolved
src/components/Shared/MultiPageLayout/MultiPageMenu/MultiPageMenu.tsx Outdated Show resolved Hide resolved
src/components/Shared/MultiPageLayout/MultiPageMenu/MultiPageMenu.graphql Outdated Show resolved Hide resolved
@dr-bizz dr-bizz force-pushed the hs-1142757-manage-organizations-link-not-working branch from c2cf1c7 to 014d25e Compare April 26, 2024 19:39
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Apr 26, 2024

@canac I've pushed it to staging

@canac
Copy link
Contributor

canac commented Apr 26, 2024

@dr-bizz Works great in staging. Thanks for fixing this! 🎉

@dr-bizz dr-bizz merged commit d35fe11 into main Apr 26, 2024
17 of 18 checks passed
@dr-bizz dr-bizz deleted the hs-1142757-manage-organizations-link-not-working branch April 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bizz @canac