MPDX-7893 - Allowing users to add offline organizations to their accounts #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against 427565b No significant changes found |
caleballdrin
approved these changes
Apr 30, 2024
dr-bizz
added
On Staging
|
Preview branch generated at https://fix-add-organization-modal.d3dytjb8adxkk5.amplifyapp.com |
canac
approved these changes
Apr 30, 2024
| @@ -153,7 +153,7 @@ export const OrganizationAddAccountModal: React.FC< | |||
| name: yup.string().required(), | |||
There was a problem hiding this comment.
Is it possible to move this schema outside of the component? I don't think it uses anything from the component closure. Having it inside the component means it will be unnecessarily recreated on every render.
…sn't recreated on every render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing error introduced in #891
Currently, on Connect Services, users aren't able to add offline organizations due to the
disableNewUsersreturning asNULLfrom GraphQL.The issue was caused by a FormIk client error. I've enabled
disableNewUsersto be nullable and added a test to ensureNULLis treated the same way asTRUE.Checklist: