Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-7894] Add user's language preference to the DataDog session #944

Merged
merged 1 commit into from
May 14, 2024
Merged

[MPDX-7894] Add user's language preference to the DataDog session #944

merged 1 commit into from
May 14, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented May 10, 2024

Description

  • Add the user's language preference to the DataDog session so that we can better understand how many of our users use MPDX in English vs in other languages.

https://jira.cru.org/browse/MPDX-7894

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label May 10, 2024
@canac canac requested a review from dr-bizz May 10, 2024 17:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against cd0696f

No significant changes found

dr-bizz
dr-bizz approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks great. Once you get it passing the test you can merge this.

@canac
Copy link
Contributor Author

canac commented May 13, 2024

@dr-bizz Thanks!

Once you get it passing the test you can merge this.

The tests are already passing. Do you mean the codecov status check?

@dr-bizz
Copy link
Contributor

dr-bizz commented May 13, 2024

Yes, the CodeCov coverage test/check

@canac canac force-pushed the 7894-datadog-all-account-list-ids branch 2 times, most recently from bc6d570 to 0e63121 Compare May 14, 2024 15:52
Base automatically changed from 7894-datadog-all-account-list-ids to main May 14, 2024 16:11
@canac canac force-pushed the 7894-datadog-language branch from 1b58186 to c3dbce2 Compare May 14, 2024 16:14
@canac canac merged commit e7bb12e into main May 14, 2024
17 of 18 checks passed
@canac canac deleted the 7894-datadog-language branch May 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz