HelpScout - 1154070 - Limit contact merge #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
added
the
Preview Environment
Bundle sizes [mpdx-react]Compared against b53eca5 No significant changes found |
|
Preview branch generated at https://limit-contact-merge.d3dytjb8adxkk5.amplifyapp.com |
|
It looks like the amplify preview is not working for some reason. |
|
The PR Preview doesn't work due to the issue on staging with constants |
|
@caleballdrin Can you review without the PR or pull it down locally? |
caleballdrin
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limiting the number of contacts a user can merge together prevents an issue like this from happening again.
I've added a limit of eight contacts. I've also added tests to ensure the functionality works.
Checklist: