MPDX-7864 - Task phases functionailty #949

dr-bizz · 2024-06-04T20:00:40Z

Description

This pull request integrates the Task phases functionality into the MPDX application. The update encompasses several areas, including task initialization, contact management, and coaching updates.

Authors: @caleballdrin & @dr-bizz

Detailed Changes

Initialization

Task Phases Functions: Set up foundational functions and hooks for task phases.
Common Functions & Components: Updated common functions, components, and tests. Pulled phase data into GraphQL constants and improved error handling.
Dashboard, Search, Reports & Tools: Updated to include new phase data and fixed related tests.

Contacts

Dynamic Statuses: Replaced hard-coded statuses with dynamic data.
Contact Details & Modals: Updated components to use new hooks, created new modals, and enhanced contact flows.
Task Logging: Added functionality to log or create tasks upon contact view changes.

Tasks

Task Modals & Helper Functions: Created and edited inputs for task modals, added helper functions, and integrated phase data into the task page.

Coaching

API Updates: Implemented API changes, fixed spelling errors, and updated mocks.
Coaching Details: Enhanced coaching details with task phase and contact statuses.

Testing

Comprehensive updates to related tests, ensuring all changes are seamlessly integrated and properly validated.

Note on Branch Change

Due to the high number of commits (140) on the previous branch "MPDX-task-phases" and the resulting merge conflicts from multiple code changes, I had to move to a new branch "MPDX-task-phases-new." This new branch was created to make it easier to create and review new commits without the complexities of resolving numerous conflicts.

This approach should provide a clearer and more manageable review process.

Checklist:

I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
I have requested a review from another person on the project

github-actions · 2024-06-04T20:02:32Z

Bundle sizes [mpdx-react]

Compared against 283ba6a

Route	Size (gzipped)	Diff
`/_app`	373.67 KB	+1.96 KB
`/accountLists`	119.32 KB	-1.19 KB
`/accountLists/[accountListId]`	270.98 KB	-1016 B
`/accountLists/[accountListId]/coaching/[coachingId]`	247.96 KB	+1.61 KB
`/accountLists/[accountListId]/contacts/flows/setup`	180.69 KB	+32.86 KB
`/accountLists/[accountListId]/reports/coaching`	247.91 KB	+1.6 KB
`/accountLists/[accountListId]/reports/designationAccounts`	243.97 KB	+2.47 KB
`/accountLists/[accountListId]/reports/expectedMonthlyTotal`	111.05 KB	+2.44 KB
`/accountLists/[accountListId]/reports/partnerCurrency/[[...contactId]]`	135.86 KB	+1.94 KB
`/accountLists/[accountListId]/reports/partnerGivingAnalysis/[[...contactId]]`	135.23 KB	+2.39 KB
`/accountLists/[accountListId]/reports/responsibilityCenters`	245.05 KB	+2.47 KB
`/accountLists/[accountListId]/reports/salaryCurrency/[[...contactId]]`	135.86 KB	+1.94 KB
`/accountLists/[accountListId]/settings/admin`	137.16 KB	+1.29 KB
`/accountLists/[accountListId]/settings/manageCoaches`	141.31 KB	+1.23 KB
`/accountLists/[accountListId]/settings/notifications`	138.97 KB	+1.43 KB
`/accountLists/[accountListId]/settings/organizations`	138.94 KB	+1.26 KB
`/accountLists/[accountListId]/settings/organizations/accountLists`	140.89 KB	+1.47 KB
`/accountLists/[accountListId]/settings/organizations/contacts`	137.68 KB	+1.47 KB
`/accountLists/[accountListId]/tasks/[[...contactId]]`	139.71 KB	+1.87 KB
`/accountLists/[accountListId]/tools`	142.28 KB	-1.12 KB
`/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]]`	218.07 KB	+1.65 KB
`/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]]`	117.35 KB	-1.2 KB
`/accountLists/[accountListId]/tools/import/csv`	106.89 KB	-1.2 KB
`/accountLists/[accountListId]/tools/import/google`	156.3 KB	-2.3 KB
`/accountLists/[accountListId]/tools/import/tnt`	149.95 KB	-2.83 KB
`/login`	119.5 KB	-1.01 KB

Dynamic import	Size (gzipped)	Diff
`../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow`	67.54 KB	+6.44 KB
`../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList`	44.75 KB	+1.85 KB
`../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap`	32.43 KB	+1.61 KB
`../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel`	8.05 KB	+1.8 KB
`../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal`	2.08 KB	-1.02 KB
`../src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/DynamicLogNewsletter.tsx -> ./LogNewsletter`	89.77 KB	-1.17 KB
`../src/components/Dashboard/ThisWeek/WeeklyActivity/WeeklyReportModal/DynamicWeeklyReportModal.tsx -> ./WeeklyReportModal`	33.15 KB	-1.39 KB
`../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts`	76.62 KB	+1.49 KB
`../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel`	108.08 KB	+2.55 KB
`../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm`	111.19 KB	+12.53 KB
`../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm`	119.29 KB	+12.73 KB
`../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm`	149.91 KB	+9.78 KB
`../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow`	67.54 KB	+6.44 KB
`../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList`	44.75 KB	+1.85 KB
`../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal`	103.91 KB	-1.58 KB

…codebase

- Pull phase data into Constants graphql - Update test wrapper to handle and report errors - Allow for more customization on common modal

…s well as fixing their tests - Updating search with new Phase data - Fixing tests in reports - Updating settings test with new Phase data - Update tools to use new phase hooks

…t status and phase data.

- Show default views if no flows saved - Reset to default views modal

…acts view page

- Mass actions - Task row

…statuses

github-actions · 2024-06-11T15:28:15Z

Preview branch generated at https://MPDX-task-phases-new.d3dytjb8adxkk5.amplifyapp.com

src/components/Shared/Filters/FilterPanel.tsx

dr-bizz · 2024-09-27T12:06:28Z

I broke the Task action in this commit 729441d - fixing now

* String conversion is unnecessary * drop will not be called if canDrop returns false

[MPDX-8256, MPDX-8255, MPDX-8259] Fix contact flows bugs

* Add phase grouping of statuses * Refactor code * Fix contact name overflowing on other text

dr-bizz added 17 commits June 4, 2024 16:22

Initialization - Setting up initial functions for task phases

125eef9

Initialization - Contact and task phases hooks to be used throughout …

b7c5d4b

…codebase

Initialization - Updating common functions, components and tests.

4018f22

- Pull phase data into Constants graphql - Update test wrapper to handle and report errors - Allow for more customization on common modal

Initialization - Updating dashboard with new Phase data

29ec996

Initialization - Update Search, Reports & Tools with new phase data a…

743d66d

…s well as fixing their tests - Updating search with new Phase data - Fixing tests in reports - Updating settings test with new Phase data - Update tools to use new phase hooks

Contacts - Replace hard-coded statuses - Caleb Alldrin

06ed4db

Contacts - Updating contact details components to use new hooks to ge…

be74fb7

…t status and phase data.

Contacts - Create contact modals

d16ad01

Contacts - Update Contact Flows view.

ec3bc27

- Show default views if no flows saved - Reset to default views modal

Contacts - Log or create task after contact moved to new View on cont…

965ae75

…acts view page

Tasks - Created/Edited inputs used on all Task Modals

9a796ce

Tasks - Modal helper functions

bc1132d

Tasks - Complete, Log & the normal task modals

91c8a6c

Tasks - Adding new phase data onto the Task page

ddb57b1

- Mass actions - Task row

Coaching - API changes, spelling and mocks

46f6de4

Coaching - Updating the Coaching details with task phase and contact …

15dc957

…statuses

**Revert when go live** Switched GHA API_URL to staging server

8016eeb

dr-bizz force-pushed the MPDX-task-phases-new branch from a8858b7 to 8016eeb Compare June 4, 2024 20:26

dr-bizz changed the title ~~Task phases functionailty~~ MPDX-7864 - Task phases functionailty Jun 4, 2024

dr-bizz mentioned this pull request Jun 4, 2024

MPDX 7864 - Adding new Task and Contact Phases #940

Closed

dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Jun 4, 2024

caleballdrin self-assigned this Jun 7, 2024

dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jun 11, 2024

caleballdrin reviewed Jun 28, 2024

View reviewed changes

src/components/Shared/Filters/FilterPanel.tsx Outdated Show resolved Hide resolved

caleballdrin added 2 commits June 28, 2024 12:30

Saved Filters allow for new lowercase statuses like never_contacted

a8db800

Saved Filters allow for new lowercase activity types and next actions

78cf6a3

caleballdrin requested a review from canac August 14, 2024 18:12

caleballdrin assigned dr-bizz Aug 14, 2024

Making useMemo a pure function again on taskModalForm

729441d

dr-bizz and others added 25 commits September 27, 2024 08:34

fixup! Making useMemo a pure function again on taskModalForm

bbcb41f

Cleaning up taskModalForm tests

5c755ba

Updating amplify.yml file to revert previews to use the staging API

abd4728

Remove unneeded TypeScript ref prop hack

97a70ca

Reduce JSX nesting

4e35214

Simplify TypeScript types

1936b21

Simplify component

69df215

Simplify dropping logic

4c92b13

* String conversion is unnecessary * drop will not be called if canDrop returns false

Ensure that the dragged item satisfies DraggedContact

eb09055

Add argument type to setPhaseId

d6f0c47

Pass in contact phase

0d35781

Use GraphQL statuses in flows options

535f22a

Use StatusEnum for all statuses

b0aec65

Remove useless key

d4710da

Convert old statuses to the new format

b937eb5

Add ResearchContactInfo status

30cad0c

Add languages (#1101)

c4d8044

Memoize options

08e2274

Make Contacts back button take the user directly to flows

1127ab4

Merge pull request #1096 from CruGlobal/8256-contact-flows-statuses

07f312f

[MPDX-8256, MPDX-8255, MPDX-8259] Fix contact flows bugs

MPDX-8306 Add phase grouping of statuses (#1100)

ca9d8a2

* Add phase grouping of statuses * Refactor code * Fix contact name overflowing on other text

Merge branch 'main' into MPDX-task-phases-new

172afe4

Merge branch 'main' into MPDX-task-phases-new

72f25ec

Remove staging API to be ready to roll to production.

2dc12cc

Make contact flow log task modal set default phase to the previous phase

9406c42

canac approved these changes Oct 2, 2024

View reviewed changes

dr-bizz merged commit 837a016 into main Oct 2, 2024
17 of 18 checks passed

dr-bizz deleted the MPDX-task-phases-new branch October 2, 2024 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MPDX-7864 - Task phases functionailty #949

MPDX-7864 - Task phases functionailty #949

dr-bizz commented Jun 4, 2024 •

edited by caleballdrin

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024

dr-bizz commented Sep 27, 2024

MPDX-7864 - Task phases functionailty #949

MPDX-7864 - Task phases functionailty #949

Conversation

dr-bizz commented Jun 4, 2024 • edited by caleballdrin Loading

Description

Authors: @caleballdrin & @dr-bizz

Detailed Changes

Initialization

Contacts

Tasks

Coaching

Testing

Note on Branch Change

Checklist:

github-actions bot commented Jun 4, 2024 • edited Loading

Bundle sizes [mpdx-react]

github-actions bot commented Jun 11, 2024

dr-bizz commented Sep 27, 2024

dr-bizz commented Jun 4, 2024 •

edited by caleballdrin

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading