-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-7930 - Clean Up Styles on Fix Mailing Addresses #952
Conversation
Bundle sizes [mpdx-react]Compared against 8229976 No significant changes found |
Preview branch generated at https://MPDX-7930-clean-up-styles.d3dytjb8adxkk5.amplifyapp.com |
@caleballdrin The codecov will come later. This is just styling. |
@dr-bizz is the amplify preview working for you? It's not working for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the Add + icon be aligned with the Lock icons and have the same circle hover effect?
@caleballdrin it's due to it building on the staging API. Can you test locally? |
…Address column is larger
Could you make the MPDX Source label aligned with the other sources? And also align the sources with the address on small screen sizes. |
Preview branch generated at https://MPDX-7930-clean-up-styles.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Changes
LockIcon
styled component.Checklist: