Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7930 - Clean Up Styles on Fix Mailing Addresses #952

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 11, 2024

Description

  • This pull request focuses on cleaning up styles on the Fix Mailing Addresses page and components to enhance visual consistency and code maintainability.

Changes

  • Added an LockIcon styled component.
  • Fixed styling for individual contact elements.
  • Updated the overall page styling to improve layout and appearance.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz changed the title Mpdx 7930 clean up styles MPDX-7930 - Clean Up Styles on Fix Mailing Addresses Jun 11, 2024
@dr-bizz dr-bizz requested a review from caleballdrin June 11, 2024 15:51
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 8229976

No significant changes found

@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jun 11, 2024
Copy link
Contributor

Preview branch generated at https://MPDX-7930-clean-up-styles.d3dytjb8adxkk5.amplifyapp.com

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jun 11, 2024

@caleballdrin The codecov will come later. This is just styling.

@caleballdrin
Copy link
Contributor

@dr-bizz is the amplify preview working for you? It's not working for me.

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the Add + icon be aligned with the Lock icons and have the same circle hover effect?

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jun 12, 2024

@caleballdrin it's due to it building on the staging API. Can you test locally?

@dr-bizz dr-bizz requested a review from caleballdrin June 12, 2024 13:32
@dr-bizz dr-bizz requested a review from caleballdrin June 12, 2024 17:30
@caleballdrin
Copy link
Contributor

Could you make the MPDX Source label aligned with the other sources? And also align the sources with the address on small screen sizes.

@caleballdrin caleballdrin added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Jun 13, 2024
Copy link
Contributor

Preview branch generated at https://MPDX-7930-clean-up-styles.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dr-bizz dr-bizz merged commit ffec90e into main Jun 13, 2024
17 of 18 checks passed
@dr-bizz dr-bizz deleted the MPDX-7930-clean-up-styles branch June 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants