Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpdx 7930 fix mailing addresses style modals #953

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 11, 2024

Description

  • This pull request addresses styling issues in the mailing address modals, improving consistency and usability by using the same Edit Mailing Address modal as we use on the contact details.

Changes

  • Switched to using the contact address modal instead of a custom one.
  • Ensured the Edit Contact modal displayed upon clicking the appropriate button.
  • Updated buttons on the contact page to allow editing and adding new contact mailing information.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from caleballdrin June 11, 2024 19:46
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jun 11, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 8229976

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixMailingAddresses 166.48 KB +73.75 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 63.96 KB +1.25 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 75.06 KB -1.62 KB

Copy link
Contributor

@dr-bizz dr-bizz changed the base branch from main to MPDX-7930-clean-up-styles June 11, 2024 19:49
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, I can't seem to save a new address when I run this locally.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jun 12, 2024

That isn't a apart of this PR.

Base automatically changed from MPDX-7930-clean-up-styles to main June 13, 2024 18:46
@dr-bizz dr-bizz merged commit a9d552f into main Jun 13, 2024
18 of 19 checks passed
@dr-bizz dr-bizz deleted the MPDX-7930-fix-mailing-addresses-style-modals branch June 13, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants