-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-7539 TntConnect Import Page #956
Conversation
Preview branch generated at https://import-tnt.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 1197576
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!
Let's move all the NextJs backend upload files into one folder called /uploads
And let's do the same on the front-end with the uploadTntConnect and upload avatar TS files.
src/components/Contacts/ContactDetails/ContactDetailsTab/Tags/ContactTags.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! Everything looks great, I did spot 2 issues. I don't know how much you can control though, as it looks like they could be API issues.
The first issue: I added a tag to all contacts when they imported. When I went to the contact, the tag read as "undefined". Screenshot 1
The second issue: I imported the TntConnect file, and removed the country of one of the contacts. I then re-imported the file but asked it to "only fill blank fields in current contacts and/or add new contacts." However, the contact's country was never filled in.
On doing the second import, I added a different tag to the contacts. This never got applied.
@dr-bizz I just fixed the issue with the undefined tags. For overwriting data, the API might not compare each of the address fields. Maybe only the whole address. I just tried overwriting and it worked for me. I had deleted the address and the person and it added it back in. It kept my existing note and added to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🔥🔥
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-7539#
file
withtag_list
andoverride
Checklist: