Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7539 TntConnect Import Page #956

Merged
merged 12 commits into from
Jun 20, 2024
Merged

MPDX-7539 TntConnect Import Page #956

merged 12 commits into from
Jun 20, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Jun 13, 2024

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-7539#

  • Creating UI
  • Using Rest API to upload file with tag_list and override
  • Success modal
  • Loading indicators

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin requested a review from dr-bizz June 13, 2024 21:47
@caleballdrin caleballdrin self-assigned this Jun 13, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Jun 13, 2024
Copy link
Contributor

Preview branch generated at https://import-tnt.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Jun 13, 2024

Bundle sizes [mpdx-react]

Compared against 1197576

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/tntConnect 128.43 KB added

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

Let's move all the NextJs backend upload files into one folder called /uploads
And let's do the same on the front-end with the uploadTntConnect and upload avatar TS files.

pages/api/upload-tnt-connect-import.page.ts Outdated Show resolved Hide resolved
pages/api/upload-tnt-connect-import.page.ts Outdated Show resolved Hide resolved
pages/api/upload-tnt-connect-import.page.ts Outdated Show resolved Hide resolved
src/components/Tool/TntConnect/TntConnect.tsx Outdated Show resolved Hide resolved
src/components/Tool/TntConnect/TntConnect.tsx Show resolved Hide resolved
src/components/Tool/TntConnect/TntConnect.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Everything looks great, I did spot 2 issues. I don't know how much you can control though, as it looks like they could be API issues.

The first issue: I added a tag to all contacts when they imported. When I went to the contact, the tag read as "undefined". Screenshot 1

The second issue: I imported the TntConnect file, and removed the country of one of the contacts. I then re-imported the file but asked it to "only fill blank fields in current contacts and/or add new contacts." However, the contact's country was never filled in.

On doing the second import, I added a different tag to the contacts. This never got applied.

Screenshot 2024-06-19 at 4 39 22 PM

Screenshot 2024-06-19 at 4 42 20 PM

@caleballdrin
Copy link
Contributor Author

caleballdrin commented Jun 19, 2024

Great work on this! Everything looks great, I did spot 2 issues. I don't know how much you can control though, as it looks like they could be API issues.

The first issue: I added a tag to all contacts when they imported. When I went to the contact, the tag read as "undefined". Screenshot 1

The second issue: I imported the TntConnect file, and removed the country of one of the contacts. I then re-imported the file but asked it to "only fill blank fields in current contacts and/or add new contacts." However, the contact's country was never filled in.

On doing the second import, I added a different tag to the contacts. This never got applied.

@dr-bizz I just fixed the issue with the undefined tags. For overwriting data, the API might not compare each of the address fields. Maybe only the whole address. I just tried overwriting and it worked for me. I had deleted the address and the person and it added it back in. It kept my existing note and added to it.

@caleballdrin caleballdrin requested a review from dr-bizz June 19, 2024 21:33
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥🔥

@caleballdrin caleballdrin merged commit 31f7a54 into main Jun 20, 2024
18 checks passed
@caleballdrin caleballdrin deleted the import-tnt branch June 20, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants