MPDX-7943 | Add Contacts Drawer to Tools #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against f58d594
|
caleballdrin
requested changes
Jun 19, 2024
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://MPDX-7943-open-contact-in-drawers-on-tools.d3dytjb8adxkk5.amplifyapp.com |
dr-bizz
force-pushed
the
MPDX-7943-open-contact-in-drawers-on-tools
branch
from
12e22aa to
613f57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the functionality to display contact details within the Tool pages, preventing the need to redirect to the Contact page. This includes the creation of a Tool Wrapper component and a Tool React hook for streamlined code.
Breakdown
setContactFocusfunction for contact display. (Like in the ContactContext).fixMailingAddress,fixCommitmentInfo,fixSendNewsletters,mergeContacts,fixEmailAddress,fixPhoneNumbers, andmergePeopleto use new contact display functionality. I apply these changes in a separate commit to make reviewing easier.fixMailingAddress.Further edits needed to work
We need additional GraphQL work for the following Tool pages
fixEmailAddressess,fixPhoneNumbers&mergePeople. I have communicated this to Andrew via Slack and commented this in the code.Tests
I have written tests for the
fixMailingAddressess, but I will not be writing tests for the other pages as it is up to the owners of those pages to write them, which they will most likely be able to copy mine.Code Coverage will fail, but it's okay. I'm making a lot of changes on files which don't currently have tests and the developers in charge of those pages will write tests for those files.
Checklist: