Helpscout - Show invalid date in person modal with error to fix #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against 31f7a54 No significant changes found |
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://person-modal-show-invalid-date.d3dytjb8adxkk5.amplifyapp.com |
dr-bizz
requested review from
canac,
wrandall22 and
caleballdrin
and removed request for
canac and
caleballdrin
wrandall22
reviewed
Jun 19, 2024
.../ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonBirthday/PersonBirthday.tsx
Outdated
Show resolved
Hide resolved
.../ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonBirthday/PersonBirthday.tsx
Outdated
Show resolved
Hide resolved
wrandall22
reviewed
Jun 20, 2024
.../ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonShowMore/PersonShowMore.tsx
Outdated
Show resolved
Hide resolved
wrandall22
approved these changes
Jun 20, 2024
…alid, format the date. I've written tests for the functions
dr-bizz
force-pushed
the
person-modal-show-invalid-date
branch
from
602a139 to
360fac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request follows the pull request at #961. In this pull request, we ensure that the Person Modal displays an error for invalid dates in order to prompt the user to make the necessary corrections.
Without this update, the input fields will remain empty and retain the incorrect values. This change will ensure that the invalid values are corrected.
Checklist: