Fix Mailing Address - Confirm buttons #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against b3e0d9a
|
dr-bizz
force-pushed
the
confirm-buttons-on-fix-mailing-addressess
branch
from
0012367 to
a3ad428
Compare
caleballdrin
requested changes
Jun 26, 2024
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://confirm-buttons-on-fix-mailing-addressess.d3dytjb8adxkk5.amplifyapp.com |
caleballdrin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I added the functionality to confirm a single contact or bulk contacts based on their source.
The functionality should be the same as MPDX Web, but I've added many more alerts to inform the user about what is happening.
When doing the bulk, we don't have a bulkAddresses GraphQl mutation, so I'm having to loop over each single Address mutation many times, which is why I put it into a promise.all() function.
The GraphQL code currently has an error; however, I can't do much about it. I have requested Andrew update the mutation to allow me to pass
primary mailing address, but until then, it will cause an error.I've added tests, but I'm unable to test the successful requests due to the GraphQL error.
Checklist: