Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7948 Rebuilding the UI - Appeals initial page #968

Merged
merged 5 commits into from
Jul 1, 2024
Merged

MPDX-7948 Rebuilding the UI - Appeals initial page #968

merged 5 commits into from
Jul 1, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 26, 2024 •
edited
Loading

Description

This PR focuses on rebuilding the UI for the Appeals initial page. The updates include simplifying the code, improving the user experience, and enhancing the functionality of the Appeals page.

Changes

  • Simplified code and improvements to the left side of the Appeals initial page.
    • Display skeletons while Appeals loads, improving the user experience during data fetching.
  • Added ToolsWrapper to the Appeals initial page.
  • Enhanced the Add Appeal form by:
    • Implementing Formik for form handling instead of using state.
    • Displaying skeletons while statuses and tags load, improving the user experience during data fetching.

I have not written tests for this, as this will come later. This PR is purely for UI on the initial appeals page.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against bdb139d

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/appeals 179.47 KB +19.74 KB

@dr-bizz dr-bizz requested a review from caleballdrin June 26, 2024 19:46
@caleballdrin
Copy link
Contributor

Could we have this box be a static alert instead of a styled div?
<Box mt={2} mb={1} className={classes.blueBox}> <Typography variant="body2"> {t( 'You can add contacts to your appeal based on their status and/or tags. You can also add additional contacts individually at a later time.', )} </Typography> </Box>

caleballdrin
caleballdrin requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Adding formik seems great for error handling. I noticed that when you add a new appeal the form doesn't clear and it doesn't get added to the list of appeals until a refresh. Maybe that is coming in a different PR?

src/components/Tool/Appeal/AddAppealForm.tsx Show resolved Hide resolved
src/components/Tool/Appeal/AddAppealForm.tsx Outdated Show resolved Hide resolved
src/components/Tool/Appeal/AppealProgressBar.tsx Show resolved Hide resolved
src/components/Tool/Appeal/AppealProgressBar.tsx Outdated Show resolved Hide resolved
@dr-bizz dr-bizz requested a review from caleballdrin June 28, 2024 13:44
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-7948-rebuilding-the-ui.d3dytjb8adxkk5.amplifyapp.com

caleballdrin
caleballdrin reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. Just some small UI changes

src/components/Tool/Appeal/AddAppealForm.tsx Outdated Show resolved Hide resolved
src/components/Tool/Appeal/AddAppealForm.tsx Show resolved Hide resolved
src/components/Tool/Appeal/AddAppealForm.tsx Outdated Show resolved Hide resolved
src/components/Tool/Appeal/AddAppealForm.tsx Outdated Show resolved Hide resolved
src/components/Tool/Appeal/AddAppealForm.tsx Show resolved Hide resolved
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jun 28, 2024

Good catches!

@dr-bizz dr-bizz requested a review from caleballdrin June 28, 2024 16:42
caleballdrin
caleballdrin approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

src/components/Tool/Appeal/Appeals.tsx
total={appeal.pledgesAmountTotal}
changePrimary={changePrimary}
/>
<Appeal appeal={appeal} changePrimary={handleChangePrimary} />
Copy link
Contributor

@caleballdrin caleballdrin Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have the "Showing 10 of 10" text be normal size and not h6?

@dr-bizz dr-bizz force-pushed the MPDX-7948-rebuilding-the-ui branch from 3f10ca1 to 3c2975b Compare July 1, 2024 13:50
@dr-bizz dr-bizz enabled auto-merge July 1, 2024 13:50
@dr-bizz dr-bizz merged commit acfac32 into main Jul 1, 2024
17 of 18 checks passed
@dr-bizz dr-bizz deleted the MPDX-7948-rebuilding-the-ui branch July 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees

@dr-bizz dr-bizz

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bizz @caleballdrin