-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8008 Ignore duplicates for Merge Contact & Merge People #970
Conversation
Bundle sizes [mpdx-react]Compared against bdb139d No significant changes found |
Preview branch generated at https://ignore-duplicates.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is look great! I've commented where you can simply the codebase by creating one function to handle both people and contacts since they use similar functionality. I also had that why did that we need an extra tests to ensure the right IDs are matched with the right action (I had some issues with this on local - it was like state got cached.)
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8008#
updateDuplicate
mutationid
of the duplicate up to theupdateDuplicate
mutationhandleBulkUpdateDuplicates()
to loop over duplicates that get ignored and also do the merge mutationChecklist: