Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8008 Ignore duplicates for Merge Contact & Merge People #970

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8008#

  • Add updateDuplicate mutation
  • Pass the id of the duplicate up to the updateDuplicate mutation
  • Add handleBulkUpdateDuplicates() to loop over duplicates that get ignored and also do the merge mutation

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin requested a review from dr-bizz June 28, 2024 02:11
@caleballdrin caleballdrin self-assigned this Jun 28, 2024
Copy link
Contributor

github-actions bot commented Jun 28, 2024

Bundle sizes [mpdx-react]

Compared against bdb139d

No significant changes found

@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Jun 28, 2024
Copy link
Contributor

Preview branch generated at https://ignore-duplicates.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is look great! I've commented where you can simply the codebase by creating one function to handle both people and contacts since they use similar functionality. I also had that why did that we need an extra tests to ensure the right IDs are matched with the right action (I had some issues with this on local - it was like state got cached.)

@caleballdrin caleballdrin requested a review from dr-bizz June 29, 2024 05:53
@dr-bizz dr-bizz merged commit 0a309ce into main Jul 9, 2024
18 checks passed
@dr-bizz dr-bizz deleted the ignore-duplicates branch July 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants