Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8021 - Fix Send Newsletter dropdown initial values #975

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

wrandall22
Copy link
Contributor

Description

Jira

This PR fixes the initial dropdown values on the fix send newsletter tool to match what the Angular app did:
If primary address: Physical
If primary address and primary email: Both
If no primary address and has primary email: Email
If neither: None
If the opt-out of email newsletters is checked, primary email does not count towards above.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wrandall22 wrandall22 added the Preview Environment Add this label to create an Amplify Preview label Jul 10, 2024
@wrandall22 wrandall22 requested a review from dr-bizz July 10, 2024 20:56
Copy link
Contributor

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 30b3ea5

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this, as the only chance I see will not prevent this from going to production

src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
@wrandall22 wrandall22 force-pushed the MPDX-8021-fix-newsletter-dropdown branch from dafba3a to 54f1cea Compare July 11, 2024 21:20
@wrandall22 wrandall22 merged commit 6764d70 into main Jul 12, 2024
18 checks passed
@wrandall22 wrandall22 deleted the MPDX-8021-fix-newsletter-dropdown branch July 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants