MPDX-7418 - Fix Email Addresses - Confirm Button #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squash
…f the emails is causing the most issues why they aren't updating. The new email gets added but replaces the last email.
wrandall22
added
the
Preview Environment
|
Preview branch generated at https://MPDX-7418-fix-email-addresses-confirm.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against e4b7269 No significant changes found |
wrandall22
force-pushed
the
MPDX-7418-fix-email-addresses-confirm
branch
from
073e57a to
ad84715
Compare
wrandall22
added
the
Waiting on another PR
wrandall22
force-pushed
the
MPDX-7418-fix-email-addresses-confirm
branch
from
78a9153 to
27c2f63
Compare
dr-bizz
reviewed
Aug 7, 2024
Comment on lines
+299
to
+302
| <Box | ||
| data-testid={`starIcon-${id}-${index}`} | ||
| onClick={() => handleChangePrimary(id, index)} | ||
| > |
There was a problem hiding this comment.
Currently you're not making a GraphQL call for just updating the primary? Will that come in a later PR?
If not, We should note that we should come back and do that. Curreently there isn't a graphQL endpoint for this, s it will need to be made or made via proxy.
There was a problem hiding this comment.
This gets handled in the confirm itself, primary is part of the payload that gets mutated. If I'm reading the Angular code correctly, it does this as well. The changes in the UI to primary are in memory until clicking the Confirm button.
dr-bizz
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira
Implements the single Confirm button for Fix Email Addresses. While testing, I found that the primary switching was not working when all emails were primary, so I fixed that as well.
Checklist: