Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7416 - Fix Email Addresses - Confirm All Button #982

Merged
merged 23 commits into from
Aug 12, 2024
Merged

MPDX-7416 - Fix Email Addresses - Confirm All Button #982

merged 23 commits into from
Aug 12, 2024

Conversation

wrandall22
Copy link
Contributor

Description

This PR implements the Confirm All button on fix email addresses.

Jira

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wrandall22 wrandall22 added the Preview Environment Add this label to create an Amplify Preview label Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-7416-fix-email-addresses-confirm-all.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 2dd9c53

No significant changes found

@wrandall22 wrandall22 added the Waiting on another PR This PR requires approval of another to be completed label Jul 25, 2024
@dr-bizz dr-bizz self-requested a review August 2, 2024 15:36
Base automatically changed from MPDX-7418-fix-email-addresses-confirm to main August 7, 2024 20:37
dr-bizz
dr-bizz approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I merged main into this PR, so you should check that I didn't miss anything. I also fixed a few things that I broke during the merge

src/components/Tool/FixEmailAddresses/FixEmailAddresses.tsx Outdated Show resolved Hide resolved
src/components/Tool/FixEmailAddresses/FixEmailAddresses.tsx Show resolved Hide resolved
src/components/Tool/FixEmailAddresses/FixEmailAddresses.tsx Show resolved Hide resolved
src/components/Tool/FixEmailAddresses/FixEmailAddresses.tsx Outdated Show resolved Hide resolved
@wrandall22 wrandall22 force-pushed the MPDX-7416-fix-email-addresses-confirm-all branch from eedbc94 to 5ee1242 Compare August 9, 2024 13:43
@wrandall22 wrandall22 requested a review from dr-bizz August 12, 2024 12:29
@wrandall22 wrandall22 removed the Waiting on another PR This PR requires approval of another to be completed label Aug 12, 2024
dr-bizz
dr-bizz approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

src/components/Tool/FixEmailAddresses/FixEmailAddresses.tsx Outdated Show resolved Hide resolved
@wrandall22 wrandall22 merged commit 773b5ee into main Aug 12, 2024
18 checks passed
@wrandall22 wrandall22 deleted the MPDX-7416-fix-email-addresses-confirm-all branch August 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrandall22 @dr-bizz