MPDX-7955 - List Header functionality #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
changed the title
Bundle sizes [mpdx-react]Compared against 0426efa No significant changes found |
dr-bizz
requested review from
wrandall22 and
caleballdrin
and removed request for
wrandall22
caleballdrin
added
the
Preview Environment
|
Preview branch generated at https://MPDX-7955-add-functionality.d3dytjb8adxkk5.amplifyapp.com |
caleballdrin
requested changes
Aug 5, 2024
caleballdrin
previously requested changes
Aug 5, 2024
|
Test chuck 4 will be resolved when merged with MPDX-7948-creating-appeal-details-pages-2 |
dr-bizz
force-pushed
the
MPDX-7948-creating-appeal-details-pages-2
branch
from
c8577b5 to
43047d2
Compare
Base automatically changed from
MPDX-7948-creating-appeal-details-pages-2
to
main
August 22, 2024 18:37
…ashes the initial appeal page.
…tyles to fit it in.
Adding more tests for appealsMainPanel to boost codecov score.
dr-bizz
force-pushed
the
MPDX-7955-add-functionality
branch
from
089ef36 to
199afc8
Compare
canac
approved these changes
Aug 22, 2024
src/components/Contacts/StarContactIconButton/StarContactIconButton.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/AppealDetails/AppealsMainPanel/AppealsMainPanelHeader.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/AppealDetails/AppealsMainPanel/AppealsMainPanelHeader.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/AppealDetails/AppealsMainPanel/AppealsMainPanelHeader.test.tsx
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| it('should disable select all contacts if no contacts', async () => { |
There was a problem hiding this comment.
Not a big deal, but some of these tests are unnecessarily async.
…sMainPanel to boost codecov score.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I add functionality to the ListHeader. Most of it is there already but I also remove some unnecessary functionality.
Added:
Removed:
Checklist: