MPDX-7955 - Add edit appeal functionality #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
changed the base branch from
MPDX-7948-creating-appeal-details-pages-2
to
MPDX-7955-add-functionality
Bundle sizes [mpdx-react]Compared against 6642dc6
|
caleballdrin
added
the
Preview Environment
|
Preview branch generated at https://MPDX-7955-add-header-info-functionality.d3dytjb8adxkk5.amplifyapp.com |
caleballdrin
approved these changes
Aug 5, 2024
|
|
||
| const EditAppealSchema: yup.SchemaOf<EditAppealFormikSchema> = yup.object({ | ||
| name: yup.string().required('Please enter a name'), | ||
| amount: yup.number().required('Please enter a goal'), |
There was a problem hiding this comment.
Maybe we could force the goal amount to be a positive number? Not necessary though.
dr-bizz
force-pushed
the
MPDX-7955-add-functionality
branch
from
089ef36 to
199afc8
Compare
dr-bizz
force-pushed
the
MPDX-7955-add-header-info-functionality
branch
from
c2648a2 to
0d73ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I added a modal that allows the user to edit the appeal's name and goal.
I've also added tests to the appeal.
Checklist: